Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artist: getAlbums and getAvailableAlbums #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Sep 26, 2013

This includes support for getAlbum() and getAvailableAlbums(). I went thru great lengths to get getAvailableAlbums() to return the same list that the spotify desktop client shows, but there is one step left which is documented in the source.

This also includes #32 since it depends on that one.

@Floby
Copy link
Owner

Floby commented Sep 27, 2013

I'm unclear on what getAvailableAlbums should return, I don't remember seeing it in the libspotify docs ?

@LinusU
Copy link
Contributor Author

LinusU commented Sep 27, 2013

Sorry, I should have been more clear. I took the liberty of adding in the getAvailableAlbums() to make this library more useful out-of-the-box. Calling getAlbums() will most likely give you a very long list with many duplicated albums, used in different regions. I took the time to try and figure out how the Spotify client does when deciding which albums to show to the user when it navigates to an artist and copied the functionality.

I thought that it might be useful to other aswell but I'll take it out if you don't want it.

@LinusU
Copy link
Contributor Author

LinusU commented Sep 27, 2013

(also, it depends on #32, not #7... I was very tired when I submitted this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants